Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: same vcs info appened twice when running jf rt build-add-git command twice #250

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

fix: same vcs info appened twice when running jf rt build-add-git command twice #250

wants to merge 21 commits into from

Conversation

gerrnot
Copy link

@gerrnot gerrnot commented Apr 19, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@eyalbe4 eyalbe4 added the bug Something isn't working label Apr 19, 2024
eyalbe4
eyalbe4 requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @gerrnot.
Please review the checks failures.

@gerrnot
Copy link
Author

gerrnot commented Apr 19, 2024 •
edited
Loading

@eyalbe4 Thanks! I found evidence that this whould be fixed by a go upgrade, so I merged the already approved (at least partly) sibling PR: #249

@EyalDelarea
Copy link
Contributor

Hey @gerrnot

We've just update to go 1.22.3,
Can you confirm that the issue is resolved by updating the go version?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gerrnot
Copy link
Author

gerrnot commented Jun 3, 2024

I have read the CLA Document and I hereby sign the CLA

JFrog Pipelines Step and others added 3 commits June 3, 2024 18:39
@gerrnot
Update build-info.json file
39204be
@gerrnot
Update build-info.json file
44387ef
@gerrnot
fix: same vcs info appened twice when running jf rt build-add-git com…
f4cdc63 
…mand twice

It turns out to be practical if you can perform issue collection
multiple times using different configurations (different regexes).
However, in this case (and in any case) you do not want to see the vcs
information duplicated. This is fixed hereby.
@gerrnot
Copy link
Author

gerrnot commented Jun 3, 2024

@EyalDelarea Thanks, yes, the build was green after that. I rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerrnot @EyalDelarea @eyalbe4